Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EditInPlace control for Identity Server picker to improve a11y #29280

Merged
merged 18 commits into from
Feb 21, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Feb 17, 2025

Extracted from #29272 to reduce changeset size.

As before this uses an EditInPlace control to show an error state with a proper error message.

Before After
image image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

.mx_UserProfileSettings button
):not(.mx_ThemeChoicePanel_CustomTheme button):not(.mx_UnpinAllDialog button):not(.mx_ShareDialog button):not(
.mx_EncryptionUserSettingsTab button
button:not(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser support for this is now okay https://developer.mozilla.org/en-US/docs/Web/CSS/:not#browser_compatibility.

I caused a bug here, and it was borderline unreadable before, having a list of selectors like this makes this a bit easier to parse.

@Half-Shot Half-Shot enabled auto-merge February 21, 2025 13:08
@Half-Shot
Copy link
Member Author

Half-Shot commented Feb 21, 2025

Approval via https://matrix.to/#/!oqOIeEMggmJDUIJWHb:matrix.org/$hTFQixgjvvtbvENHE9Z7oP31lGJKc80D-l6S9om8FUQ?via=element.io&via=matrix.org&via=half-shot.uk

However we should rethink the phone and email fields above this input, as it's quite jarring for them to pop-in. #29330

@Half-Shot Half-Shot added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit 22943ee Feb 21, 2025
31 checks passed
@Half-Shot Half-Shot deleted the hs/identity-server-picker-modernize branch February 21, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants