-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EditInPlace control for Identity Server picker to improve a11y #29280
Conversation
.mx_UserProfileSettings button | ||
):not(.mx_ThemeChoicePanel_CustomTheme button):not(.mx_UnpinAllDialog button):not(.mx_ShareDialog button):not( | ||
.mx_EncryptionUserSettingsTab button | ||
button:not( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Browser support for this is now okay https://developer.mozilla.org/en-US/docs/Web/CSS/:not#browser_compatibility.
I caused a bug here, and it was borderline unreadable before, having a list of selectors like this makes this a bit easier to parse.
However we should rethink the phone and email fields above this input, as it's quite jarring for them to pop-in. #29330 |
Extracted from #29272 to reduce changeset size.
As before this uses an EditInPlace control to show an error state with a proper error message.
Checklist
public
/exported
symbols have accurate TSDoc documentation.