Gtk4 skeleton #2549
Draft
Gtk4 skeleton #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts fixed : # libcore/DndHandler.vala # meson.build # src/View/AbstractDirectoryView.vala # src/View/Sidebar/BookmarkRow.vala
|
Because I want this PR not to require detailed review as a whole because the diff will be large. If the merged PRs have already been independently reviewed at least for coding rationality then this PR will only need reviewing for overall functionality and appearance. |
# Conflicts fixed: # filechooser-portal/Main.vala # libcore/AbstractSlot.vala # libcore/FileUtils.vala # plugins/pantheon-files-trash/plugin.vala # src/Dialogs/ChooseAppDialog.vala # src/View/DirectoryNotFound.vala # src/View/Window.vala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this is to provide an intermediate branch which compiles (but does not necessarily run atm) with Gtk4 to which small branches may be pushed porting different aspects of the code. This allows for a series of manageable reviews and approvals.
The non-compiling code has the for the most part been commented out except where a very simple fix is possible or it was not possible to fix by just commenting code out.
Branches pushed to this branch should incrementally replace commented out code with working Gtk4 code with as small a diff as practical.
As of 745e1a7, this compiles and runs with no terminal messages - but only shows an empty window.
@danirabbit Is there a way of having PRs that are to be merged into this branch require at least 1 approving review?
--PRs be merged--