Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants: add numeric css class #745

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 10, 2025

We're currently manually using pango for tnum features in a number of places: https://github.com/search?q=org%3Aelementary+tnum+language%3AVala&type=code&l=Vala

Adds numeric style class which has precedent in Adwaita: https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/217

Created a new CssClass namespace in line with: #741

@danirabbit danirabbit marked this pull request as ready for review February 10, 2025 18:23
@danirabbit danirabbit requested a review from a team February 10, 2025 18:23
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected. Note that it depends on itself to compile the demo so you have to install without the demo option first and then again with the demo option. Presumably this will not affect the final package?

@danirabbit
Copy link
Member Author

Yeah CI builds it fine and we haven't had issues with since breaking package builds before that I'm aware of

@danirabbit danirabbit merged commit fff6d43 into main Feb 11, 2025
5 checks passed
@danirabbit danirabbit deleted the danirabbit/cssclass_numeric branch February 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants