Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainWindow: fallback to checking for installer if proc/cmdline fails #735

Closed

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 30, 2024

In #733 we switched methods for checking for proc/cmdline. Add a fallback to the old method of looking for the installer in case that doesn't work for some reason

Also go ahead and select that default session if it exists

Might fix #734 🤷‍♀️

@danirabbit
Copy link
Member Author

I don't see anything in journalctl that would imply that this is failing, but doesn't hurt to have a fallback. It's more likely the issue is that select session bit

@danirabbit danirabbit requested a review from ryonakano May 30, 2024 15:59
@ryonakano
Copy link
Contributor

This didn't worked for me unfortunatelly:

screen

FYI I'm testing with the following steps:

  1. Install this branch and the latest Installer main branch
  2. Fake the /proc/cmdline with the following command: cat /proc/cmdline | tr -d '\n' > /tmp/cmdline; echo " boot=casper" >> /tmp/cmdline && sudo mount -B /tmp/cmdline /proc/cmdline
  3. Logout
  4. Don't forget sudo umount /proc/cmdline after testing

@ryonakano
Copy link
Contributor

Closing since #733 is reverted in #736.

@ryonakano ryonakano closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer window is not shown
2 participants