Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mutter 47 support #772

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Add Mutter 47 support #772

merged 2 commits into from
Nov 10, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Nov 7, 2024

Fixes #744

Can rebase merge if desired

Remove extra vapi

Add ifdefs for color

fix missed spot, color from string
@danirabbit danirabbit force-pushed the danirabbit/mutter-47 branch from e2a3ebb to 47734da Compare November 7, 2024 23:26
@danirabbit danirabbit marked this pull request as ready for review November 7, 2024 23:27
@danirabbit danirabbit requested a review from a team November 7, 2024 23:27
@stsdc
Copy link
Member

stsdc commented Nov 7, 2024

So many ifs... Are there concepts of a plan to drop them in the future?

@danirabbit
Copy link
Member Author

We can probably drop support for Mutter <= 13 since we're not releasing to Jammy anymore, but I think that should be proposed in another branch

@danirabbit
Copy link
Member Author

Actually looks like Gentoo is still using 13, so maybe 12? Will need input from others

@bobby285271
Copy link
Member

For NixOS, we pin Mutter to 43 but we definitely will unpin and bump to 46 when we bump gala to 8.x so this is not an issue for NixOS. I previously made a small script in elementary/gala#1496 's PR description that can semi (since it requires e.g. taking care #elif manually) automatically clean up these ifs.

@stsdc
Copy link
Member

stsdc commented Nov 10, 2024

Do we have a list of distros that we want to support?

@danirabbit
Copy link
Member Author

@stsdc I don't think so. But either way I think that's outside of the scope of this PR. I'm just trying to unbreak Fedora here 😅

@stsdc
Copy link
Member

stsdc commented Nov 10, 2024

I think it is ok to merge this and immediately prepare a draft PR that will remove #if blocks when the newer Mutter version will arrive in Fedora.

@danirabbit danirabbit merged commit 882336b into master Nov 10, 2024
5 checks passed
@danirabbit danirabbit deleted the danirabbit/mutter-47 branch November 10, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

add support for mutter 47 / libmutter-15
3 participants