Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklist ubuntu-advantage-tools #68

Closed
wants to merge 2 commits into from
Closed

Blacklist ubuntu-advantage-tools #68

wants to merge 2 commits into from

Conversation

jepotter1-archive
Copy link
Contributor

@jepotter1-archive jepotter1-archive commented Apr 5, 2021 •
edited
Loading

danirabbit
danirabbit requested changes Apr 6, 2021
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep these in alphabetical order please :)

@jepotter1-archive
Copy link
Contributor Author

jepotter1-archive commented Apr 6, 2021 •
edited
Loading

@danrabbit Done.

@danirabbit
Copy link
Member

Actually, testing removing this package locally, it removes ubuntu-minimal. So, I think before we can do this we need to either:
a. Account for everything in Ubuntu minimal ourselves and not depend on that
b. Ask upstream to make ubuntu-advantage-tools a recommends instead of depends

@jepotter1-archive
Copy link
Contributor Author

jepotter1-archive commented Apr 6, 2021 •
edited
Loading

@danrabbit Thanks for testing it out. I'll go ahead and make a PR sometime later that replaces ubuntu-minimal with a custom package set. That way all Ubuntu bloat can be avoided!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit requested changes

@davidmhewitt davidmhewitt Awaiting requested review from davidmhewitt

@tintou tintou Awaiting requested review from tintou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blacklist ubuntu-advantage-tools
2 participants
@jepotter1-archive @danirabbit