Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrefersColorSchemeSettings: Remove reference to Granite #40

Merged
merged 5 commits into from
Oct 18, 2021

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 6, 2021

Pretty much just reverts #21

After elementary/granite#529 the source of truth for Granite.Settings is the settings daemon, so this is a bit of a circular reference.

AFAICT, this is only used to set the value of org.freedesktop.prefers-color-scheme which is unused

@danirabbit danirabbit mentioned this pull request Oct 13, 2021
2 tasks
@danirabbit danirabbit requested a review from a team October 13, 2021 19:00
Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill it with fire

@cassidyjames cassidyjames merged commit b6ce9da into master Oct 18, 2021
@cassidyjames cassidyjames deleted the colorschemesettings-nogranite branch October 18, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants