wip

eliasecchig · Sep 18, 2024 · 9ef7293 · 9ef7293
1 parent 5f25b40
commit 9ef7293
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/gemini/sample-apps/conversational-genai-app-template/deployment/terraform/dev/storage.tf b/gemini/sample-apps/conversational-genai-app-template/deployment/terraform/dev/storage.tf
@@ -8,14 +8,14 @@ terraform {
 }
 
 resource "google_storage_bucket" "logs_data_bucket" {
-  name     = "${var.dev_project_id}-logs-data"
-  location = var.region
-  project  = var.dev_project_id
+  name                        = "${var.dev_project_id}-logs-data"
+  location                    = var.region
+  project                     = var.dev_project_id
   uniform_bucket_level_access = true
 
   lifecycle {
     prevent_destroy = true
-    ignore_changes = all
+    ignore_changes  = all
   }
 
   # Use this block to create the bucket only if it doesn't exist

diff --git a/gemini/sample-apps/conversational-genai-app-template/deployment/terraform/storage.tf b/gemini/sample-apps/conversational-genai-app-template/deployment/terraform/storage.tf
@@ -1,3 +1,12 @@
+terraform {
+  required_providers {
+    google = {
+      source  = "hashicorp/google"
+      version = "~> 6.3.0"
+    }
+  }
+}
+
 locals {
   all_projects = [
     var.cicd_runner_project_id,

diff --git a/gemini/sample-apps/conversational-genai-app-template/deployment/terraform/variables.tf b/gemini/sample-apps/conversational-genai-app-template/deployment/terraform/variables.tf
@@ -95,7 +95,7 @@ variable "artifact_registry_repo_name" {
 variable "cloud_run_app_roles" {
   description = "List of roles to assign to the Cloud Run app service account"
   type        = list(string)
-  default     = [
+  default = [
     "roles/aiplatform.user",
     "roles/discoveryengine.editor",
     "roles/logging.logWriter",
@@ -107,7 +107,7 @@ variable "cloud_run_app_roles" {
 variable "cicd_roles" {
   description = "List of roles to assign to the CICD runner service account in the CICD project"
   type        = list(string)
-  default     = [
+  default = [
     "roles/storage.admin",
     "roles/run.invoker",
     "roles/aiplatform.user",
@@ -120,6 +120,6 @@ variable "cicd_roles" {
 
 variable "cicd_sa_deployment_required_roles" {
   description = "List of roles to assign to the CICD runner service account for the Staging and Prod projects."
-  type    = list(string)
-  default = ["roles/run.developer", "roles/iam.serviceAccountUser"]
+  type        = list(string)
+  default     = ["roles/run.developer", "roles/iam.serviceAccountUser"]
 }