Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ready for review #1

Closed
wants to merge 22 commits into from

Conversation

LuminaScript
Copy link
Contributor

Review of the delta-kernel Tool

This pull request introduces the delta-kernel tool, which generates compile-time version update analyses between two Linux kernel versions.

@LuminaScript LuminaScript marked this pull request as draft July 22, 2024 18:23
@LuminaScript LuminaScript marked this pull request as ready for review July 22, 2024 18:23
@LuminaScript
Copy link
Contributor Author

I am creating a pull request to merge into the main repository. Thanks for your review! @mk3890 @rhodesconover8 @matthew-l-weber

@matthew-l-weber
Copy link
Collaborator

@chuckwolber

@LuminaScript LuminaScript force-pushed the opensource_review branch 3 times, most recently from a341a5f to 7d80169 Compare July 25, 2024 19:08
Copy link
Collaborator

@mk3890 mk3890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build_scripts/build_collect_diff.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build_scripts/tokenize.py Outdated Show resolved Hide resolved
build_scripts/build_collect_diff.sh Outdated Show resolved Hide resolved
build_scripts/git_shortlog.sh Outdated Show resolved Hide resolved
build_scripts/parse_dep_list.py Outdated Show resolved Hide resolved
build_scripts/parse_json.py Outdated Show resolved Hide resolved
build_scripts/tokenize.py Outdated Show resolved Hide resolved
generate_web_reports.sh Outdated Show resolved Hide resolved
generate_web_reports.sh Outdated Show resolved Hide resolved
run_tool.sh Outdated Show resolved Hide resolved
build_scripts/build_collect_diff.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
build_scripts/build_collect_diff.sh Outdated Show resolved Hide resolved
@matthew-l-weber
Copy link
Collaborator

@chuckwolber @mk3890 I'll take on most of these changes when I'm back. I wanted to have @LuminaScript publish a draft before she's done this next week!

@LuminaScript
Copy link
Contributor Author

LuminaScript commented Jul 27, 2024

Thank you!

@LuminaScript
Copy link
Contributor Author

@chuckwolber The latest commit should have addressed all the concerns you pointed out in the comments. Thank you for reviewing my code! Please let me know if any further changes are needed.

Copy link

@chuckwolber chuckwolber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing your tool I found a few things that you may need to fix.

README.md Show resolved Hide resolved
build_scripts/build_collect_diff Outdated Show resolved Hide resolved
build_scripts/build_collect_diff Outdated Show resolved Hide resolved
build_scripts/build_collect_diff Outdated Show resolved Hide resolved
build_scripts/build_collect_diff Outdated Show resolved Hide resolved
build_scripts/build_collect_diff Outdated Show resolved Hide resolved
generate_build_filelists Outdated Show resolved Hide resolved
LuminaScript and others added 11 commits July 31, 2024 17:38
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
LuminaScript and others added 11 commits July 31, 2024 17:38
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Co-authored-by: Chuck Wolber <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
Signed-off-by: Yizhen Zhang <[email protected]>
@matthew-l-weber
Copy link
Collaborator

I found a dependency bug; tooling needs to run inside a container. (will make a ticket)

Parsing git line info in file: security/selinux/include/security.h
Parsing git line info in file: security/selinux/include/policycap_names.h
Parsing git line info in file: security/selinux/ss/sidtab.h
Diff info stored in /tmp/tmpy4q7b9ra
starting tokenize function test
Result exported to tokenize.json
Traceback (most recent call last):
  File "/wip/delta-kernel/linux/scripts/change-impact-tools/build_scripts/tokenize", line 335, in <module>
    os.remove(intermediate_file_path)
NameError: name 'os' is not defined

@matthew-l-weber
Copy link
Collaborator

Moved a rebased set of changes with some fixups to PR2 - https://github.com/elisa-tech/delta-kernel/pull/3/files

@matthew-l-weber
Copy link
Collaborator

Thank you @LuminaScript for the great summer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants