callgraph: make pre-push target pass with newer pandas versions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Read all callgraph csv fields as strings to match queries also in cases where datatypes might not match - Fix warnings reported by newer pycodestyle versions - Fix build error with travis on python 3.7, reference: https://travis-ci.community/t/build-error-for-python-3-7-on-two-different-projects/12895 Signed-off-by: Henri Rosten <[email protected]>
|
@bulwahn : I wanted to try using the callgraph tool in a personal project, but noticed the query_callgraph.py no longer worked with latest pandas version. Also, noticed some other issues with travis builds, which are now also fixed with this PR. I'm not sure if https://github.com/elisa-tech/workgroups is maintained anymore, or if you are the maintainer but in case you are, could we merge this PR to make the query_callgraph.py usable again and fix current CI issues. |
|
@henrirosten thanks for providing the patch. I will check with @bulwahn to give also his approval to have a 4 eyes review on your patch. Thanks for fixing the issues. |
pahmann
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henri Rosten [email protected]