-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CheckList for Safety Claims on a Generic Linux System.md #28
Conversation
595ef97
to
3a9a8f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but a few typos / grammar nits to address
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
Contributions/CheckList_for_Safety_Claims_on_a_Generic_Linux_System.md
Outdated
Show resolved
Hide resolved
@igor-stoppa In general, I would prefer to keep the number of individual commits in a PR to a minimum, so that the history is more readable. Would you be OK to rebase -i this to e.g. batch the review updates into a single commit? Or alternatively I could do a squash on merge (although I'm not sure how GitHub handles attributions and signatures when that happens). |
@reiterative sure I can. How would you prefer that I mention your contributions in the commit message? |
Please use: Co-authored-by: Paul Albertella [email protected] (Turns out I had the privacy checkbox ticked in GitHub, hence the odd 'noreply' email) |
Checklist-by: Igor Stoppa <[email protected]> Co-authored-by: Paul Albertella [email protected] Signed-off-by: Igor Stoppa <[email protected]>
Cosmetic: Fix the index layout. Signed-off-by: Igor Stoppa <[email protected]>
Add Index Signed-off-by: Igor Stoppa <[email protected]>
Fix spacing in broken nested lists Signed-off-by: Igor Stoppa <[email protected]>
281e62d
to
3216567
Compare
Signed-off-by: Igor Stoppa <[email protected]>
@reiterative I think it should be done, but I'll leave it to you to decide if it's ok to pull the trigger and merge |
This is the first cut of the checklist proposed during last Autumn ELISA workshop