Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration file and sharing as read only #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fkasumovic
Copy link

No description provided.

Faruk Kasumovic added 3 commits August 16, 2020 15:26
Per default configuration file will be ignored or will be loaded from $HOME/.tty-share if this file exists. A non-default config file behaviour can be changed using -config flag to specify a config file name.
@andys8
Copy link

andys8 commented Sep 23, 2020

Sharing readonly would be pretty nice

// CLI options override any config file settings, having config file is useful
// for changing default options
func (conf *TTYShareConfig) Load() {
defConfigFileName := os.Getenv("HOME") + "/." + path.Base(os.Args[0])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider following the XDG Base Directory Specification on where to save configuration files!
https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

@steadysupply
Copy link

This work would be easier for (@elisescu?) to review if it was introduced in two separate PRs, one for adding config file support and one for adding read-only support. I also feel like read-only support should have some corresponding implementation over in https://github.com/elisescu/tty-server so it's clear to the user in the browser that they can't input ... !

@strazto
Copy link
Contributor

strazto commented Dec 15, 2020

I second the request for config files - In place of that, for now we've the option of aliasing alias tty-share=tty-share -public -proxy our.proxy.server etc, but this would be ideal.
(Also, following XDG-CONFIG conventions would be amazing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants