layout fixes #82
layout fixes #82
Conversation
| - | ||
| scope: | ||
| path: "pages/about" | ||
| values: | ||
| type: "pages" | ||
| sidebar: about |
There was a problem hiding this comment.
Removed by accident but not needed anyway.
| @@ -16,10 +16,8 @@ theme_variables: | |||
| theme_color: 205a86 | |||
| topnav: | |||
| brand_logo: assets/img/main_logo.svg | |||
| #privacy_statement_url: https://elixir-europe.org/privacy | |||
There was a problem hiding this comment.
It was decided that no privacy page is needed since no cookies are tracked.
| fonts: | ||
| - https://fonts.googleapis.com/css2?family=Lato:ital,wght@0,400;0,700;1,400;1,700&display=swap | ||
| # - https://fonts.googleapis.com/css2?family=PT+Sans:ital,wght@0,400;0,700;1,400;1,700&display=swap |
There was a problem hiding this comment.
This otherwise duplicated line is commented out so not useful to keep around.
| - | ||
| scope: | ||
| path: "" | ||
| type: "pages" | ||
| values: | ||
| permalink: "/:basename" | ||
| layout: "page" | ||
| sidebar: main |
There was a problem hiding this comment.
This is a default for the "Main" button that was decided to be removed from the navbar.
| - | ||
| scope: | ||
| path: "pages/contribute" | ||
| values: | ||
| type: "pages" | ||
| sidebar: contribute |
There was a problem hiding this comment.
It was decided that the default Contribute button should be removed from the navbar.
| @@ -1,4 +1,4 @@ | |||
| copyright: 'This site uses Cookies. We use cookies to help the website run effectively. To find out more, read our [Privacy](https://elixir-europe.org/privacy) and [Cookies](https://elixir-europe.org/cookies) statements.' | |||
There was a problem hiding this comment.
It was decided that the privacy and cookie notices should be removed from the footer. It was also decided to add in a copyright notice. My suggestion is to skip adding in the years. If that would be desired, the implementation should be automatic, i.e., not requiring the years to be edited manually.
| - url_text: Contribute | ||
| url: "pages/contribute" |
There was a problem hiding this comment.
It was decided to move the Contribute link in the footer.
| - title: Privacy | ||
| url: /privacy |
There was a problem hiding this comment.
It was decided the privacy page is not needed.
| @@ -1,4 +1,4 @@ | |||
| title: Lifecycle | |||
There was a problem hiding this comment.
It was decided that the Lifecycle should be renamed to Training Lifecycle.
| - title: Main | ||
| url: /index |
There was a problem hiding this comment.
It was decided that the Main button should be removed from the navbar.
| @@ -1,13 +1,10 @@ | |||
| ## | |||
| ## if you want to list an external url, use external_url instead of url. the theme will apply a different link base. | |||
| subitems: | |||
| - title: Main | |||
| url: /index | |||
| - title: Lifecycle | |||
There was a problem hiding this comment.
It was decided that the navbar button Lifecycle should instead be Training lifecycle.
| - title: Contribute | ||
| url: /how_to_contribute |
There was a problem hiding this comment.
It was decided to remove the link Contribute from the navbar.
| @@ -1,6 +1,6 @@ | |||
| <div class="row row-bg-light justify-content-center mb-5"> | |||
| <div class="col-12"> | |||
| <div class="text-center display-6 mb-5 pb-3">Training Life Cycle</div> | |||
There was a problem hiding this comment.
It was decided that the correct spelling is lifecycle in one word.
| <div class="count bg-{{ number.color}} rounded py-4"> | ||
| <div class="count bg-{{ number.color}} rounded py-4 pe-5"> | ||
| <i class="{{ number.icon }}"></i> | ||
| <div class="count-number display-2 text-center text-white"> | ||
| <div class="count-number display-3 text-end text-white"> | ||
| {{ number.number }} | ||
| </div> | ||
| <div class="count-number-title text-center text-white mt-1"> |
There was a problem hiding this comment.
This slightly reduces the font of the digits, and aligns them to the right, to make the layout more consistent since the numbers in the footer can be 2, 3 and 4 digits long.
| @@ -26,7 +26,7 @@ | |||
| $(this).prop('Counter', 0).animate({ | |||
| Counter: $(this).text() | |||
| }, { | |||
| duration: 1000, | |||
There was a problem hiding this comment.
This increases the duration of the animation with the numbers increasing from 1s to 2s.
| @@ -7,7 +7,7 @@ | |||
| {% unless include.hideHeading %} | |||
| <h2>Testimonials</h2> | |||
| {% endunless %} | |||
| <div id="carouselTestimonials" class="carousel carousel-testimonials bg-primary rounded slide"> | |||
There was a problem hiding this comment.
I've implemented a lighter shade for the testimonials area.
| @@ -6,6 +6,7 @@ $green: #03CEA4; | |||
| $orange: #FF7900; | |||
|
|
|||
| $primary: $aubergine; | |||
| $primary-light: mix(#fff, $primary, 40%); | |||
There was a problem hiding this comment.
This is defining a lighter shade of the primary color as a variable.
| .bg-primary-light { | ||
| background: $primary-light; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is defining a CSS class for a background that uses the new primary-light color.
|
|
||
| #ett-logo { | ||
| display: none; | ||
| visibility: hidden; | ||
| } |
There was a problem hiding this comment.
This is a CSS hack to hide the ETT logo in the footer.
|
|
||
| .nav-break { | ||
| display: none; | ||
| } | ||
|
|
||
| .nav-item:nth-last-child(2) { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
This is a CSS hack to hide the GitHub button in the navbar that otherwise cannot be hidden away.
|
Pinging here 🔔 hoping for a review |
|
Ready to merge, @mihai-sysbio on your own 👍 |
Thanks @ahornos |
Resolving #78 and some parts of #62 and #63.