Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instructions in duplicate translation error #122

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix instructions in duplicate translation error #122

merged 1 commit into from
Nov 16, 2023

Conversation

maennchen
Copy link
Member

@maennchen maennchen commented Nov 16, 2023 •
edited
Loading

@maennchen maennchen added the enhancement New feature or request label Nov 16, 2023
@maennchen maennchen self-assigned this Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 535a7f1486bb84041fa6011f1c342e9b3d8387c2-PR-122

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.054%
Totals Coverage Status
Change from base Build 8ee1c57834ffa81ffa23a0d136fd390d2467fc53: 0.0%
Covered Lines: 419
Relevant Lines: 423
💛 - Coveralls

saveman71
saveman71 approved these changes Nov 16, 2023
View reviewed changes
Copy link

@saveman71 saveman71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to fix the doc here too?

expo/lib/mix/tasks/expo.msguniq.ex

Line 14 in 8ee1c57

mix expo.msguniq PO_FILE [--output=OUTPUT_FILE]

@maennchen maennchen force-pushed the jm/precise_duplicate_error branch from 92fb560 to 9258069 Compare November 16, 2023 09:34
@maennchen
Copy link
Member Author

@saveman71 Good catch

@maennchen maennchen force-pushed the jm/precise_duplicate_error branch 2 times, most recently from d1c8ba6 to 6849857 Compare November 16, 2023 09:50
@maennchen maennchen mentioned this pull request Nov 16, 2023
Merged
@maennchen maennchen force-pushed the jm/precise_duplicate_error branch from 61b56ec to 535a7f1 Compare November 16, 2023 10:25
@whatyouhide whatyouhide changed the title Precise instructions in duplicate translation error Fix instructions in duplicate translation error Nov 16, 2023
@whatyouhide whatyouhide merged commit a6ed7f0 into main Nov 16, 2023
11 checks passed
@whatyouhide whatyouhide deleted the jm/precise_duplicate_error branch November 16, 2023 11:40
@whatyouhide
Copy link
Contributor

Awesome 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatyouhide whatyouhide whatyouhide left review comments

@saveman71 saveman71 saveman71 approved these changes

Assignees

@maennchen maennchen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maennchen @whatyouhide @saveman71