Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: call apply/3 as intended #598

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix: call apply/3 as intended #598

merged 2 commits into from
Oct 13, 2024

Conversation

preciz
Copy link
Contributor

@preciz preciz commented Oct 12, 2024

Thank you for reviewing.

polvalente
polvalente approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@polvalente polvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be nice to add a small test for this edge case

@preciz
Copy link
Contributor Author

preciz commented Oct 12, 2024

I added a test that fails with the old code but succeeds with the new one.

@polvalente polvalente merged commit ce2e247 into elixir-nx:main Oct 13, 2024
4 of 5 checks passed
@polvalente
Copy link
Contributor

Merged with the failing EXLA test because it's already failing in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polvalente polvalente polvalente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preciz @polvalente