Address deprecation; prefer ExUnit.Case.register_test/6 #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanderhoop
added a commit
to vanderhoop/elixir
that referenced
this pull request
Jun 6, 2024
while addressing the `ExUnit.Case.register_test/3` deprecation in elixir-wallaby/wallaby#776, I wondered how long `register_test/6` had been around. In looking at the source and the docs, I uncovered what I believe is an incorrect `since` attribute
vanderhoop
force-pushed
the
address-register-test-deprecation
branch
from
bb8066e
to
05247fa
Compare
- ExUnit.Case.register_test/6 has been available since Elixir 1.11.0,
and now triggers deprecation warnings as of Elixir 1.17
vanderhoop
force-pushed
the
address-register-test-deprecation
branch
from
05247fa
to
80f473b
Compare
|
Thanks! |
josevalim
pushed a commit
to elixir-lang/elixir
that referenced
this pull request
Jun 6, 2024
while addressing the `ExUnit.Case.register_test/3` deprecation in elixir-wallaby/wallaby#776, I wondered how long `register_test/6` had been around. In looking at the source and the docs, I uncovered what I believe is an incorrect `since` attribute
josevalim
pushed a commit
to elixir-lang/elixir
that referenced
this pull request
Jun 6, 2024
while addressing the `ExUnit.Case.register_test/3` deprecation in elixir-wallaby/wallaby#776, I wondered how long `register_test/6` had been around. In looking at the source and the docs, I uncovered what I believe is an incorrect `since` attribute
1 task
alinmarsh
pushed a commit
to TernSystems/wallaby
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExUnit.Case.register_test/6has been available since Elixir 1.11.0, and now triggers deprecation warnings as of Elixir 1.17. This would be a breaking change if the intention is to support Elixir versions prior to 1.11, but I think we're all good on that front, given the existing CI version matrix