fix: Fix Incorrect Tweet ID Parameter Passed to sendTweet Function (#…

…2430) * correct id * skip action if model is not supported * warn * update warn
elizaOS · Jan 17, 2025 · f4e54ca · f4e54ca
1 parent a44fa94
commit f4e54ca
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 17 deletions.
diff --git a/packages/client-twitter/src/search.ts b/packages/client-twitter/src/search.ts
@@ -284,7 +284,7 @@ export class TwitterSearchClient {
                         response,
                         message.roomId,
                         this.twitterUsername,
-                        tweetId
+                        selectedTweet.id
                     );
                     return memories;
                 };

diff --git a/packages/plugin-node/src/services/image.ts b/packages/plugin-node/src/services/image.ts
@@ -189,7 +189,6 @@ class OpenAIImageProvider implements ImageProvider {
     }
 }
 
-
 class GroqImageProvider implements ImageProvider {
     constructor(private runtime: IAgentRuntime) {}
 
@@ -233,7 +232,6 @@ class GroqImageProvider implements ImageProvider {
     }
 }
 
-
 class GoogleImageProvider implements ImageProvider {
     constructor(private runtime: IAgentRuntime) {}
 
@@ -299,11 +297,18 @@ export class ImageDescriptionService
         this.runtime = runtime;
     }
 
-    private async initializeProvider(): Promise<void> {
+    private async initializeProvider(): Promise<boolean> {
         if (!this.runtime) {
             throw new Error("Runtime is required for image recognition");
         }
 
+        const availableModels = [
+            ModelProviderName.LLAMALOCAL,
+            ModelProviderName.GOOGLE,
+            ModelProviderName.OPENAI,
+            ModelProviderName.GROQ,
+        ].join(", ");
+
         const model = models[this.runtime?.character?.modelProvider];
 
         if (this.runtime.imageVisionModelProvider) {
@@ -326,15 +331,17 @@ export class ImageDescriptionService
                 this.provider = new OpenAIImageProvider(this.runtime);
                 elizaLogger.debug("Using openai for vision model");
             } else if (
-                this.runtime.imageVisionModelProvider ===
-                ModelProviderName.GROQ
+                this.runtime.imageVisionModelProvider === ModelProviderName.GROQ
             ) {
                 this.provider = new GroqImageProvider(this.runtime);
                 elizaLogger.debug("Using Groq for vision model");
             } else {
-                elizaLogger.error(
-                    `Unsupported image vision model provider: ${this.runtime.imageVisionModelProvider}`
+                elizaLogger.warn(
+                    `Unsupported image vision model provider: ${this.runtime.imageVisionModelProvider}. ` +
+                        `Please use one of the following: ${availableModels}. ` +
+                        `Update the 'imageVisionModelProvider' field in the character file.`
                 );
+                return false;
             }
         } else if (model === models[ModelProviderName.LLAMALOCAL]) {
             this.provider = new LocalImageProvider();
@@ -350,8 +357,15 @@ export class ImageDescriptionService
             this.provider = new OpenAIImageProvider(this.runtime);
         }
 
-        await this.provider.initialize();
-        this.initialized = true;
+        try {
+            await this.provider.initialize();
+        } catch (error) {
+            elizaLogger.error(
+                `Failed to initialize the image vision model provider: ${this.runtime.imageVisionModelProvider}`
+            );
+            return false;
+        }
+        return true;
     }
 
     private async loadImageData(
@@ -416,15 +430,17 @@ export class ImageDescriptionService
         imageUrl: string
     ): Promise<{ title: string; description: string }> {
         if (!this.initialized) {
-            await this.initializeProvider();
+            this.initialized = await this.initializeProvider();
         }
 
-        try {
-            const { data, mimeType } = await this.loadImageData(imageUrl);
-            return await this.provider!.describeImage(data, mimeType);
-        } catch (error) {
-            elizaLogger.error("Error in describeImage:", error);
-            throw error;
+        if (this.initialized) {
+            try {
+                const { data, mimeType } = await this.loadImageData(imageUrl);
+                return await this.provider!.describeImage(data, mimeType);
+            } catch (error) {
+                elizaLogger.error("Error in describeImage:", error);
+                throw error;
+            }
         }
     }
 }