-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Hebrew README Translation #1023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
changed the title
Add Hebrew README Translation
docs: Add Hebrew README Translation
Dec 12, 2024
monilpat
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this: Please add a reference to this readme in the main readme as the other language translations do thanks
fix: code fence alignment
I appreciate you pointing that out, it should be referenced accordingly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Add Hebrew (RTL) translation
Risks
Low - This is a documentation-only change adding a new translation file.
Background
Adds Hebrew (RTL) translation of the main README.md file as README_HE.md, including:
What kind of change is this?
Improvements (adds new language support to existing documentation)
Documentation changes needed?
My changes are documentation changes themselves - adding a new translated README file.
Testing
Where should a reviewer start?
Detailed testing steps
As anon/reviewer, go to https://github.com/lessuselesss/eliza/blob/update_docs/README_HE.md
Discord username
Adam Turner | lessuseless (ar4s_45979)