Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Hebrew README Translation #1023

Merged
merged 19 commits into from
Dec 13, 2024

Conversation

lessuselesss
Copy link
Contributor

@lessuselesss lessuselesss commented Dec 12, 2024

Relates to:

Add Hebrew (RTL) translation

Risks

Low - This is a documentation-only change adding a new translation file.

Background

Adds Hebrew (RTL) translation of the main README.md file as README_HE.md, including:

  • Full translation of all main sections
  • RTL text direction support using HTML/CSS
  • Proper Hebrew character rendering
  • Maintained all links and functionality from original README

What kind of change is this?

Improvements (adds new language support to existing documentation)

Documentation changes needed?

My changes are documentation changes themselves - adding a new translated README file.

Testing

Where should a reviewer start?

  1. Open README_HE.md in either VSCode/Cursor/github.dev's Markdown preview
  2. Verify RTL formatting is correct
  3. Check that all links are functional
  4. Verify Hebrew text renders properly

Detailed testing steps

As anon/reviewer, go to https://github.com/lessuselesss/eliza/blob/update_docs/README_HE.md

  1. View the raw file to verify RTL tags and Hebrew text
  2. View the rendered file to verify proper RTL formatting
  3. Check that language selector at top includes Hebrew link
  4. Verify all internal links work correctly
  5. Ensure images and formatting match main README.md structure

Discord username

Adam Turner | lessuseless (ar4s_45979)

@monilpat monilpat changed the title Add Hebrew README Translation docs: Add Hebrew README Translation Dec 12, 2024
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this: Please add a reference to this readme in the main readme as the other language translations do thanks

@lessuselesss
Copy link
Contributor Author

I appreciate you pointing that out, it should be referenced accordingly now.

@monilpat monilpat merged commit 601ae51 into elizaOS:update_docs Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants