fix: Duplicate twitter posts. #1329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test failing due to non PR issue in CI: |
|
yoinked in: #1339 :') |
tcm390
approved these changes
Dec 21, 2024
odilitime
approved these changes
Dec 21, 2024
|
Closing as contained in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#1284
Risks
LOW - could miss a post, or post less, but seems posting once correctly now on server boot.
Background
What does this PR do?
This PR fixes duplicate Twitter posts on Eliza server boot.
I think this was a mistake from a revert last week, can see git blame:
generateNewTweetLoop()is being ran twice with no conditionals onpost.start()What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Why are we doing this? Any context or related work?
Twitter agents should not duplicate post on boot.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Before boot, see duplicates, after changes, only 1 post:
Where should a reviewer start?
Try boot twitter agent with fresh delay, note no duplicate posts.
Detailed testing steps
Start with fresh twitter account, no delay, boot server, look at profile timeline for duplicate posts.
Discord username
cjft