-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RP for plugin-tee-verifiable-log-api #1333
RP for plugin-tee-verifiable-log-api #1333
Conversation
@madjin I noticed that PRs #1331 and #1333 were reopened and the #1260 PR closed, which has left me a bit confused about the current direction. Should I merge my changes into the develop branch, or is there a different branch we should treat as the standard? I’ve submitted #1369. both cpppppp7 and I have been working diligently to make progress on this code contribution. I’d appreciate any clarification to ensure we align our efforts effectively. 😊 |
Closing in favor of #1369 |
Relates to:
Risks
Low
Background
What does this PR do?
This PR builds upon
plugin-tee-verifiable-log
by modifying the direct client to add remote attestation and query interfaces for verifiable logs.To better understand what verifiable logs are and why we implemented this feature, it is necessary to refer to the preceding PR that introduces
plugin-tee-verifiable-log
and provides the context for its development.What kind of change is this?
Documentation changes needed?
Yes, we will add documentation about api detail.
Testing
Where should a reviewer start?
Understand the existing
plugin-tee
plugin-tee
and use its key derivation interface.To better understand what verifiable logs are and why we implemented this feature, it is necessary to refer to the preceding PR that introduces
plugin-tee-verifiable-log
and provides the context for its development.Understand what
plugin-tee-verifiable-log
doesDetailed testing steps
It have completed the integration tests and can run the
xx
file in the test directory.