Fix: Duplicate tweet scheduling loops in start method

[jasonqindev]

• Resolved an issue where generateNewTweetLoop was called twice in the start method of /packages/client-twitter/src/post.ts.
• The method was invoked at line 174 and line 190 without any conditional checks, leading to two independent tweet scheduling loops being created.
• Removed one of the redundant generateNewTweetLoop calls to ensure only a single scheduling loop is initialized.

Fixes #1395

Relates to:

Issue #1395

Risks

Low: Removing the redundant call ensures only one scheduling loop, minimal impact on other functionalities.

Background

What does this PR do?

This PR fixes an issue where generateNewTweetLoop was called twice, leading multiple tweets to be posted. It ensures only a single scheduling loop is initialized by removing the redundant call.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Start by reviewing the start method in /packages/client-twitter/src/post.ts, focusing on the removal of the redundant generateNewTweetLoop call.

Detailed testing steps

1. Configure the Twitter client and set POST_IMMEDIATELY=true to enable immediate tweet posting.
2. Start the service and observe if two tweets are sent, and check if the log contains multiple Next tweet scheduled in xxx minutes messages.
3. Verify that after starting the service, only one tweet is sent and the Next tweet scheduled in xxx minutes message is logged only once.
4. Confirm that tweets are still being scheduled correctly without any issues.

[samarth30]

I think generateNewTweetLoop(); this second loop is applied in case processActionsLoop in being executed.

if (enableActionProcessing) {
            processActionsLoop().catch((error) => {
                elizaLogger.error(
                    "Fatal error in process actions loop:",
                    error
                );
            });
            generateNewTweetLoop();
        } else {
            elizaLogger.log("Action processing loop disabled by configuration");
        }

If you can keep generateNewTweetLoop() function in the if condition then it will be good to merge

[jasonqindev]

I think generateNewTweetLoop(); this second loop is applied in case processActionsLoop in being executed.

if (enableActionProcessing) {
            processActionsLoop().catch((error) => {
                elizaLogger.error(
                    "Fatal error in process actions loop:",
                    error
                );
            });
            generateNewTweetLoop();
        } else {
            elizaLogger.log("Action processing loop disabled by configuration");
        }

If you can keep generateNewTweetLoop() function in the if condition then it will be good to merge

I've updated the code to move generateNewTweetLoop() inside the if (enableActionProcessing) block as suggested.

[samarth30]

LGTM

[jasonqindev]

It seems that this should be merged into the develop branch, but I merged it into main instead. I will close this PR and create a new one.