fix: replace hardcoded model class with dynamic parameter #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
issue #1439
Description
In the
generateText
function, the model type was hard-coded, preventing the function from dynamically switching models based on external parameters.model class
fromgenerateText
andgenerateMessageResponse
.Risks
generateText
andgenerateMessageResponse
function.Background
generateText
andgenerateMessageResponse
did not allow dynamic model switching based on incoming parameters, limiting flexibility and making it cumbersome to use different models in various scenarios.What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
generateText
andgenerateMessageResponse
now handles the incoming model parameter, and verify that any calling code is appropriately updated to use this new parameter.Detailed testing steps
generateText
andgenerateMessageResponse
with a specific model parameter, confirming that it correctly switches to the chosen model.