Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client-twitter: fix ENABLE_ACTION_PROCESSING logic #1463

Merged

Conversation

zkvm
Copy link
Contributor

@zkvm zkvm commented Dec 26, 2024

Relates to:

Risks

Low

Background

Setting ENABLE_ACTION_PROCESSING=false in .env file will not work as enableActionProcessing will always be non-nullish no matter ENABLE_ACTION_PROCESSING set to true or false.

What does this PR do?

Update the code so ENABLE_ACTION_PROCESSING would work as expected. This fix also is consistent with #1392

What kind of change is this?

Bug fixes

Documentation changes needed?

No

Testing

Where should a reviewer start?

Detailed testing steps

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zkvm! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@zkvm zkvm changed the title fix ENABLE_ACTION_PROCESSING logic fix: fix ENABLE_ACTION_PROCESSING logic Dec 26, 2024
@shakkernerd shakkernerd merged commit 9c5b91e into elizaOS:develop Dec 26, 2024
2 of 3 checks passed
@odilitime odilitime changed the title fix: fix ENABLE_ACTION_PROCESSING logic fix: client-twitter: fix ENABLE_ACTION_PROCESSING logic Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants