Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding plugin for Cronos ZKEVM #1464

Merged
merged 10 commits into from
Dec 26, 2024
Merged

feat: Adding plugin for Cronos ZKEVM #1464

merged 10 commits into from
Dec 26, 2024

Conversation

samarth30
Copy link
Collaborator

Relates to:

#1128

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

I have tested the branch by building it locally. LGTM

Screenshot 2024-12-26 at 4 20 13 PM

Where should a reviewer start?

Detailed testing steps

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samarth30! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@samarth30 samarth30 requested a review from odilitime December 26, 2024 11:01
@samarth30 samarth30 changed the title Thomas/cronos zkevm Adding plugin for Cronos ZKEVM Dec 26, 2024
@samarth30 samarth30 added the Plugin_new Mark PRs that are a new plugin label Dec 26, 2024
@shakkernerd shakkernerd changed the title Adding plugin for Cronos ZKEVM feat: Adding plugin for Cronos ZKEVM Dec 26, 2024
@samarth30 samarth30 requested review from shakkernerd and removed request for odilitime December 26, 2024 12:02
@shakkernerd shakkernerd merged commit 99106da into develop Dec 26, 2024
4 of 5 checks passed
@shakkernerd shakkernerd deleted the thomas/cronos-zkevm branch December 26, 2024 13:20
@samarth30
Copy link
Collaborator Author

@thomas-nguy thanks for your contribution and efforts. your PR is merged 🚀

@jonathangus
Copy link
Contributor

This PR broke the integration tests. I think the issue might be related to the import of @elizaos/plugin-cronoszkEVM instead of @elizaos/plugin-cronoszkevm

Skärmavbild 2024-12-26 kl  15 29 35

@shakkernerd
Copy link
Member

Fixed in #1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plugin_new Mark PRs that are a new plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants