Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugin-story): merge the two readme files into one file #1681

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jan 2, 2025

Relates to:

We have two Readme in the directory packeges/plugin-story:

image

It seems annoying for the developers to read which one is the correct one.

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

@0xaguspunk
Copy link
Contributor

Also the naming causes some funky git behavior :/

monilpat
monilpat previously approved these changes Jan 2, 2025
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please resolve merge conflicts first thanks :)

@9547 9547 force-pushed the plugin-story-dup-readme branch from 4e8464a to 96ad0c9 Compare January 3, 2025 01:16
@9547 9547 requested a review from monilpat January 3, 2025 01:16
@9547
Copy link
Contributor Author

9547 commented Jan 3, 2025

@monilpat conflict resolved, please take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants