refactor: (prop) improving API error handling for coinbase integration #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai16z-demirix
changed the title
lostgirldev
reviewed
Jan 4, 2025
Comment on lines
39
to
41
| function parseErrorResponse(responseText: string): Record<string, any> { | ||
| try { | ||
| return JSON.parse(responseText); |
There was a problem hiding this comment.
@ai16z-demirix The parseErrorResponse function should handle cases where responseText is not a valid JSON string. Consider logging the error or throwing a specific error to aid debugging.
There was a problem hiding this comment.
Good point. Introduced new changes @lostgirldev
Comment on lines
118
to
121
| if ((400 <= response.status && response.status <= 499) || | ||
| (500 <= response.status && response.status <= 599)) { | ||
| const errorDetails = getErrorDetails(response, responseText); | ||
| throw new CoinbaseError(errorDetails, response.status, response); |
There was a problem hiding this comment.
@ai16z-demirix Ensure that the error handling in handleException does not expose sensitive information. The error message should be sanitized before being thrown to avoid leaking details about the API or system.
There was a problem hiding this comment.
Good point and thank you. Introduced new changes. @lostgirldev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#1735
Risks
Medium: Error handling in Coinbase integration can be affected.
Background
What does this PR do?
This PR improves handling for APi errors from Coinbase.
What kind of change is this?
Improvement.
Regarding issue: #1735
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Changed files:
packages/plugin-coinbase/advanced-sdk-ts/src/rest/errors.ts
packages/plugin-coinbase/advanced-sdk-ts/src/rest/rest-base.ts
Detailed testing steps
Running agent and try to consume Coinbase API.