-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aligned SB with the new PG scheme (#1389) #1800
base: develop
Are you sure you want to change the base?
fix: aligned SB with the new PG scheme (#1389) #1800
Conversation
You added all 3 sql right ?
Seed
Schema
Rpc
In supabsse ?
And no logging of the error seem strange because we have error handling now.
…On Sun, Jan 5, 2025 at 03:08, Patrick ***@***.***(mailto:On Sun, Jan 5, 2025 at 03:08, Patrick <<a href=)> wrote:
[11.png (view on web)](https://github.com/user-attachments/assets/9ecdd4a5-affb-40d0-abde-439cc2ce3b40)
I followed all the steps but it's showing me this
—
Reply to this email directly, [view it on GitHub](#1800 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BE5QO4H3WYBSTQYX6MHJO3L2JA5TXAVCNFSM6AAAAABUSYYVMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGM4TSNRVGU).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
yeah i added all the 3 sql, yes in supabase. im using 0.1.7.1-alpha.2 right now. |
Thank you, I tried again but still no luck. Same error. Take your time! |
…plementation - Add dynamic embedding dimension validation\n- Implement robust circuit breaker pattern for database operations\n- Add comprehensive error handling for memory operations\n- Improve validation checks for memory fields and UUID formats\n- Add retry mechanism with exponential backoff for database operations\n- Enhance logging for better error tracking and debugging
…eddings implementation to properly use RPC functions - Updated memory creation error handling in tests - Improved type safety in agent initialization - Ensured consistent behavior across database operations
I resolved the RPC problem in Supabase that was trying to write into a document table that was not existing. |
…again and the table management in the index.ts
I did a coordinate test with the user that is collaborating and sue supabase also with various clients. |
Awesome, happy collaborating with you! |
@hellopleasures Is it all good now ? |
@AIFlowML yes, we can merge this. all clear and ready to merge. sorry for late response. i have fever this past few days. |
@odilitime @shakkernerd @azep-ninja During conflict resolution with develop, I've identified an important consideration: PR #1620 (merged last week) introduced the RAGKnowledgeItem feature for knowledge system separation and multi-agent RAG optimization. My PR (#1800) contains a complete rework of the Supabase adapter to align with the new PostgreSQL schema. Current situation:
I need guidance on how to proceed:
I've paused the merge process until we decide the best approach to preserve both the new schema alignment and the RAGKnowledgeItem functionality. This is only related to the file packages/adapter-supabase/src/index.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A LOT of plugins are removed, going to need some extra time/effort to merge this one
PR: Rebuild Supabase Adapter with PostgreSQL Schema Alignment #1389
Overview
This PR rebuilds the Supabase adapter to align with the new PostgreSQL adapter schema, improving consistency across database adapters and enhancing functionality.
Key Changes
1. Schema Alignment
2. New SQL Files
seed.sql
for testing and developmentrpc_functions.sql
with improved database functions3. Documentation
readme.md
with:4. Code Quality
src/index.ts
any
typesTesting
Technical Details
Database Functions
create_room
: Room initializationremove_memories
: Memory cleanupsearch_memories
: Vector similarity searchget_embedding_list
: Cached embedding retrievalget_goals
: Goal managementcheck_vector_extension
: Vector extension validationSchema Improvements
Migration Notes
Security Considerations
Next Steps