fix(solana token provider): await cached data #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentatum
force-pushed
the
fix/await-cached-prices-2
branch
from
668b688 to
0628d3a
Compare
bentatum
force-pushed
the
fix/await-cached-prices-2
branch
4 times, most recently
from
4003263 to
7367010
Compare
|
Thanks, @monilpat. I rebased a few times, so this will need your re-approval. |
bentatum
force-pushed
the
fix/await-cached-prices-2
branch
from
7367010 to
02384d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Executing trades
Risks
low
Background
I was unable to execute a trade unless I made these changes
What does this PR do?
Awaits cached data because the function returns a promise. If we don't await, then the results are always not null and the logic is incorrect and likely fails downstream.
What kind of change is this?
It's a bug fix
Documentation changes needed?
None
Testing
Where should a reviewer start?
Detailed testing steps