add github to client enumerations #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpi-ai
pushed a commit
to 0xpi-ai/NayariAI
that referenced
this pull request
Jan 15, 2025
add github to client enumerations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Adding the github to the
Clientsenumeration due to error when trying to run. `Invalid enum value'Risks
Low risk
Background
Since the github client is live 0.1.7 it cant be used when adding to a character because its not part of the Client enum
What does this PR do?
Adds
GITHUBto the client enumWhat kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps