Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork: Pr/1628 -Replaces the current plugin with Solana Agent Kit #2288

Closed
wants to merge 15 commits into from

Conversation

wtfsayo
Copy link
Member

@wtfsayo wtfsayo commented Jan 14, 2025

Fork

#1628

Relates to:

#1619

Risks

Low

Background

What does this PR do?

Replace the solana plugin with solana agent kit

  • wrapper around the runtime for the kit
  • replace the trade function with trade action from the kit
  • replace the transfer function with transfer action from the kit
  • replace the swap dao function with trade action from the kit

What kind of change is this?

This PR improves the existing plugin by replacing with the Solana Agent Kit
In following days, will add more actions from the agent kit.

Testing

Where should a reviewer start?

packages/plugin-solana

Reference docs https://sendaifun.github.io/solana-agent-kit/

Detailed testing steps

None, automated tests are fine.

Discord username

0xaryan

@wtfsayo
Copy link
Member Author

wtfsayo commented Jan 14, 2025

I think it looks good; I wouldnt replace solana plugin; there is already a solana agent kit plugin we can replace that with this one

@thearyanag
Copy link
Contributor

hey @wtfsayo - was afk

any specific reason to not replace the existing plugin-solana

@wtfsayo
Copy link
Member Author

wtfsayo commented Jan 14, 2025

hey @wtfsayo - was afk

any specific reason to not replace the existing plugin-solana

kinda opinionated, depending on your end! best to let users choose what they want!

@thearyanag
Copy link
Contributor

hey @wtfsayo - was afk
any specific reason to not replace the existing plugin-solana

kinda opinionated, depending on your end! best to let users choose what they want!

got it, do you want me to change the folder structure or do any other changes?

@wtfsayo
Copy link
Member Author

wtfsayo commented Jan 14, 2025

hey @wtfsayo - was afk
any specific reason to not replace the existing plugin-solana

kinda opinionated, depending on your end! best to let users choose what they want!

got it, do you want me to change the folder structure or do any other changes?

just the folder structure make it replace Solana-agent-kit plugin! bring back the base plugin; can open new PR

@wtfsayo wtfsayo closed this Jan 14, 2025
@thearyanag
Copy link
Contributor

hey @wtfsayo - pls review this here, #2458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants