Feature/thin floor nft opportunities #2289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice - Add comprehensive createListing method for Reservoir API - Include parameter validation and default values - Implement error handling and performance monitoring - Generate marketplace URL for listed token
…Service - Add comprehensive getFloorListings method for Reservoir API - Support sorting by price and rarity - Implement detailed error handling and performance monitoring - Transform API response to standardized format
…omprehensive documentation for thin floor detection - Explained watchlist management and buying strategies - Added code examples for opportunity detection - Highlighted performance considerations and best practices
…d NFTWatchlist export
…ties tweet action and enhanced thin floor detection
…proved type safety
…ysis, and performance tracking
…d optional metadata
…taste assessment methods
- Improved error handling in API key configurations - Added custom Ethereum address validation - Updated service initializations - Enhanced configuration flexibility - Removed ethers dependency
…nular error types and codes, introduced error severity and correlation ID, improved error factory and handler, enhanced retry and telemetry mechanisms
…guration, error handling, and logging
…hemy API - Implemented AlchemyService with methods for NFT ownership, metadata, transfer history, collection insights, market analytics, token rarity scoring, and collection search - Uses native fetch for API interactions - Provides robust error handling - Supports flexible querying of NFT data
|
please send a clean PR; too many files checked in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Link to Issue or Ticket
Risks
Medium. Changes involve updates to the NFT collections plugin, which could affect data aggregation, market intelligence features, and introduce new experimental features.
Background
What does this PR do?
This PR enhances the NFT collections plugin by:
What kind of change is this?
Documentation changes needed?
My changes require a change to the project documentation. I have updated the documentation accordingly to reflect the new features, services, and experimental functionalities.
Changes Overview
Actions
get-collections.ts,list-nft.ts,sweep-floor.ts, andtweet-alpha.tsto support new thin floor detection logic and daily tweet publishing.Services
alchemy.ts,cache-manager.ts,coingecko.ts,market-intelligence.ts,opensea.ts,rate-limiter.ts,reservoir.ts,security-manager.ts, andsocial-analytics.tsfor enhanced data processing and security.reservoir.tsto ensure correct retrieval of floor prices from the Reservoir API.Evaluators
nft-knowledge.ts,nft-taste-evaluator.ts, andnft-taste-expert.tsto assess NFT trends and tastes.New Feature
tweet-alpha.ts: Added functionality to publish daily tweets about NFT buying opportunities and curated collections, leveraging thin floor detection and curated collection insights.Tested using mock data generation and load testing to ensure the new features work as expected without degrading performance.