Handle mouse clicks for systray items #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major benefit of MenuItem is automatic handling of context menus. However, MenuItem cannot properly process right mouse click, making it less useful. Hence, this patch replaces it (as long as the container) with a simple EventBox and process button clicks on our own.
|
Looks great, thanks a lot! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relocated from ralismark#6
This implements mouse button click handling for systray icons. Meanwhile, the building widgets MenuBar/MenuItem are replaced with Box/EventBox to fulfill the event hooking.
Additional Notes
gtk::Windowis subclassed just to store its global coordinates, which appears to be a bit overkill, but I didn't come up with better ideas. This could be further polished.Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing