Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sysinfo/linux-netdevs feature #1096

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

shouya
Copy link
Contributor

@shouya shouya commented May 5, 2024

This PR removes the linux-netdevs feature from sysinfo dependency.

Rationale: I recently discovered the issue of non-responding eww resulting from a seemingly unrelated bad nfs mount. From what's stated in the API documentation, enabling linux-netdevs can result in hangs in sysinfo::Disks APIs when there are network mounts.

I found this feature was enabled in #958, in an attempt to fix a EWW_NET display issue. However, despite the naming suggests, sysinfo/linux-netdevs has nothing to do linux network interfaces. As can be seen from this search, the only place linux-netdevs takes effect is to determine whether or not network filesystems are included in the Disks API.

Therefore, I concluded that this feature may be added accidentally.

@elkowar elkowar merged commit 3dca22d into elkowar:master May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Normalize EWW_NET Units
2 participants