Remove sysinfo/linux-netdevs feature #1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the linux-netdevs feature from sysinfo dependency.
Rationale: I recently discovered the issue of non-responding eww resulting from a seemingly unrelated bad nfs mount. From what's stated in the API documentation, enabling linux-netdevs can result in hangs in sysinfo::Disks APIs when there are network mounts.
I found this feature was enabled in #958, in an attempt to fix a
EWW_NET
display issue. However, despite the naming suggests,sysinfo/linux-netdevs
has nothing to do linux network interfaces. As can be seen from this search, the only placelinux-netdevs
takes effect is to determine whether or not network filesystems are included in the Disks API.Therefore, I concluded that this feature may be added accidentally.