fix: fix changelog, warnings and lints #1155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #1144 I noticed some new warnings when compiling. I'm assuming some warnings were stabilized or added.
This pr fixes these warnings, yielding a slight performance increase, for more details see below.
These are some breaking internal changes since APIs are modified and some call sites might now require generic annotations.
Replacing the field
display_backend
in theApp
struct withPhantomData
This field is never read, producing a warning when compiling with 1.80.0.
It seems to only exist for the type parameter
B
, which has not been restricted toDisplayBackend
even though it probably should be.By replacing it with a
PhantomData
, there is no need to pass theDisplayBackend
around at all times since all the information this argument provides is already encoded in the generic type parameters.Removal of field
instance_id
in theEwwWindow
structThis field is never read, producing a warning when compiling with 1.80.0.
All information it holds is already in the key of the
open_windows
map in theApp
struct. Removing it also makes theWindowInitiator
'sid
field obsolete.Checklist
I don't think this is necessary here
cargo fmt
to automatically format all code before committing