MINOR: better anchors #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix local $this->allowed_types (elliot-sawyer#27)
Add the option to create a link to an elemental anchor.
Firesphere
requested changes
Oct 20, 2023
| @@ -17,9 +17,16 @@ | |||
| "require": { | |||
| "silverstripe/framework": "^4 || ^5", | |||
| "unclecheese/display-logic": "^2 || ^3", | |||
| "giggsey/libphonenumber-for-php": "^8.0" | |||
| "giggsey/libphonenumber-for-php": "^8.0", | |||
| "sheadawson/silverstripe-dependentdropdownfield": "dev-master" | |||
There was a problem hiding this comment.
A library shouldn't rely on a dev-master requirement
| "repositories": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/anhld/silverstripe-dependentdropdownfield" |
There was a problem hiding this comment.
This won't propagate through to the root composer install.
| $owner->Title = $element->Title; | ||
| } | ||
| $owner->Querystring = $owner->Querystring ? str_replace('?', '', (string) $owner->QueryString) : $owner->Querystring; | ||
| $owner->Anchor = $owner->Anchor ? str_replace('#', '', (string) $owner->Anchor) : $owner->Anchor; |
There was a problem hiding this comment.
This looks overly complicated.
A simple $owner->Querystring = ltrim((string)$owner->Querystring, '?'); would suffice.
|
|
||
| // add QueryString | ||
| if(!empty($this->QueryString)) { | ||
| if(strpos($LinkURL, '?') === false && strpos($this->QueryString, '?') === false) { |
There was a problem hiding this comment.
strpos should be str_contains
The check on the QueryString seems pointless, as this is stripped out already earlier.
|
|
||
| // add anchor | ||
| if(!empty($this->Anchor)) { | ||
| if(strpos($LinkURL, '#') === false && strpos($this->Anchor, '#') === false) { |
| $sitetree_field_label = $config->get('sitetree_field_label') ?: 'MenuTitle'; | ||
|
|
||
| // Get source data for the ElementID field | ||
| $anchorOptions = function ($pageID) { |
There was a problem hiding this comment.
For readability, semantics and debug-ability, this should be an actual method, instead of an anonymous function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.