Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation review #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Documentation review #4

wants to merge 3 commits into from

Conversation

paulajulve
Copy link
Collaborator

Most of it are style changes to the way the README file explains the uses of the library. Ideally, I would like to break down this file into several files with links, making the main file more of an index, easier to get a high level view from without going into detail. But I'll leave that for a potential future PR.

There are also a couple of behaviour changes:

  • default address connection for clients and servers on 127.0.0.1:8080
  • capitalisation of BroadCast function to Broadcast, to reflect it's a single word

Both are in separate commits to be able to be either accepted or discarded easily.

Copy link
Owner

@eloylp eloylp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paulajulve , many thanks for your contributions ! 🏗️

I like the idea you mentioned about splitting the README.md into multiple files and then make an index which would point to them. We could take a look later. Maybe wait for the incoming features, which are going to add more docs and then make the refactor.

I see there are parts of the documentation changes like:

-  "the user also has access to all low level observability middlewares"
+ "you have access to all low level observability middlewares"

My thoughts: I consider the use of a third person like narrative its more appropriate for technical docs. We dont know who is reading them. It could be a user or just a reviewer. By using the third person narrative, we leave that assignment to the readers brain 🧠 . I would like to know your thoughts/opinions on this 💭

I think we should point this PR to the develop branch. Also, follow the CHANGELOG.md guidelines, which i think in this case would be to add this PR link to the unreleased section. This its already reflected in docs, but maybe they are not clear enough. Just let me know and we can change them. The idea is to buffer all changes in develop and then make a release, whenever we consider there are enough, meaningful features for users.

Looks like there is a failing test. Some days ago, i experimented the same in other Cis, just restarted them to make the CI pass. But of course, its not a good solution. I think its time to move the CI log into an issue, and start solving the problem in a separate work stream. Here is the issue . Please, in the meanwhile , feel free to just restart the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants