Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve labelling for plot_quality() #119

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Improve labelling for plot_quality() #119

merged 5 commits into from
Sep 6, 2024

Conversation

mdingemanse
Copy link
Contributor

Simple commit and updated test plot to address #116, seems ready for review

@mdingemanse mdingemanse marked this pull request as ready for review August 26, 2024 19:14
@mdingemanse
Copy link
Contributor Author

See this issue for something I'm running into with tests

@mdingemanse
Copy link
Contributor Author

@PabRod i think the failing tests here on this PR have to do with the same issue as #118 and I would like to resolve it so that i can produce PRs that do not fail tests — any insights?

@PabRod PabRod added the bug Something isn't working label Sep 2, 2024
@PabRod
Copy link
Contributor

PabRod commented Sep 2, 2024

The problem is that the snapshot seems to be different than expected. It might be related to #118, but I'm not 100% sure. I'll try it in my laptop as soon as possible.

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-plots.R:53:3'): Plot quality ─────────────────────────────────
  Snapshot of `plot_quality_with_save(testdata)` to 'plots/plot_quality.png' has changed
  * Download and unzip run artifact
  * Copy 'tests/testthat/_snaps/plots/plot_quality.new.png' to local test directory
  * Run `testthat::snapshot_review('plots/')` to review changes

The code generating this figure changed, but the new snapshot was not uploaded
@PabRod PabRod merged commit 93b6ae4 into main Sep 6, 2024
3 checks passed
@mdingemanse mdingemanse deleted the 116-plot_quality branch September 16, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants