Track eden and edenB #1108
Open
Track eden and edenB #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
==========================================
+ Coverage 48.04% 48.15% +0.11%
==========================================
Files 894 896 +2
Lines 35068 35173 +105
==========================================
+ Hits 16848 16939 +91
- Misses 16961 16975 +14
Partials 1259 1259 |
avkr003
requested changes
Jan 20, 2025
| if amt.Empty() { | ||
| return nil | ||
| } | ||
|
|
||
| // Emit event to track Eden and EdenB send amount | ||
| ctx.EventManager().EmitEvent( |
There was a problem hiding this comment.
SendCoinsFromModuleToModule already emit events
| if err != nil { | ||
| return err | ||
| } | ||
| if amt.Empty() { | ||
| return nil | ||
| } | ||
|
|
||
| // Emit event to track Eden and EdenB burn amount | ||
| ctx.EventManager().EmitEvent( |
There was a problem hiding this comment.
BurnCoins already emit events
There was a problem hiding this comment.
It won't when amount is zero, see lines later, burn coins won't get coins so will not emit event
avkr003
requested changes
Jan 22, 2025
| store.Set(types.TotalSupplyKeyPrefix, b) | ||
| } | ||
|
|
||
| func (k Keeper) V9_SetSupply(ctx sdk.Context) { |
There was a problem hiding this comment.
There might be some Eden which will already be converted to Elys, we need to add that as well.
There was a problem hiding this comment.
currently we are tracking total supply in DS, should I add one more variable to track total minted ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What has Changed?
What specific problem were you aiming to address, and how did you successfully resolve it? If tests were not uploaded for this pull request or if coverage decreased, please provide an explanation for the change.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking changeDeployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.