fix: Allow quick navigation with (centaur-tabs-{backward,forward}--button) #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton) * To do so: Unbind (delete-other-windows) at [centaur-tabs-display-line double-mouse-1] * Note: Function (delete-other-windows) is already bound at [mode-line mouse-2]
|
Can you elaborate on the situation? 🤔 I don't see the UX problem here. Thanks! |
Sure! Let me know if you can reproduce the following issue: (I'm using the latest centaur-tabs from MELPA using GNU Emacs 27.1) Actual behavior:
Expected behavior (OK after applying the PR):
|
|
Hi @jcs090218 ! Was my explanation clear enough? or do you need more details Kind regards. |
|
Sorry for the late reply! I did not know there was a forward button since I switch tabs using the key more often. 🤔 I might have overlooked this customization. |
|
OK thanks @jcs090218 ! Indeed, I now realize that this feature is not "on" by default... so to give full context: 
|
jcs090218
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@jcs090218 I recently noticed that when clicking "too fast" on centaur-tabs-forward-button (resp. …-backward-…) several times, centaur-tabs only moves one tab at a time… which was quite distracting from a UX point of view.
This PR fixes this 🙂
Remarks
This patch is simpler than what I was expecting:
Unbind (delete-other-windows) at [centaur-tabs-display-line double-mouse-1]
This is not a loss in functionality, given:
Function (delete-other-windows) is already bound at [mode-line mouse-2]