Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct type for integers with defcustom #242

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

gessen
Copy link
Contributor

@gessen gessen commented Sep 21, 2024

The correct type for integers defined with defcustom is integer, using int makes customize-group and setopt signal errors.

@@ -136,11 +136,6 @@
:group 'centaur-tabs
:type 'string)

(defcustom centaur-tabs-label-fixed-length 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is defined also in centaur-tabs-functions.el. It's used only in that file as well.

@jcs090218 jcs090218 merged commit 3d78b1e into ema2159:master Sep 21, 2024
10 checks passed
@jcs090218
Copy link
Collaborator

Thank you!

@gessen gessen deleted the fix/custom-int branch October 5, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants