fix: hale: Removal of project variable is not persisted on save

Removing of a variable via settings dialog is persisted in the project file upon save.

ING-4169

ui/plugins/eu.esdihumboldt.hale.ui/src/eu/esdihumboldt/hale/ui/service/project/internal/ProjectVariablesPreferencePage.java

@@ -138,18 +138,18 @@ public void widgetSelected(SelectionEvent e) {
 				InputDialog dialog = new InputDialog(display.getActiveShell(), "Add new variable",
 						"Please enter the name of the variable to add", "", new IInputValidator() {
 
-					@Override
-					public String isValid(String newText) {
-						if (newText == null || newText.isEmpty()) {
-							return "Variable name must not be empty";
-						}
-						else if (variables.containsKey(newText)) {
-							return "Variable already exists";
-						}
-
-						return null;
-					}
-				});
+							@Override
+							public String isValid(String newText) {
+								if (newText == null || newText.isEmpty()) {
+									return "Variable name must not be empty";
+								}
+								else if (variables.containsKey(newText)) {
+									return "Variable already exists";
+								}
+
+								return null;
+							}
+						});
 				if (dialog.open() == InputDialog.OK) {
 					String varName = dialog.getValue();
 					if (varName != null) {
@@ -205,6 +205,8 @@ public void widgetSelected(SelectionEvent e) {
 						c.dispose();
 					}
 					variables.remove(varName);
+					varControls.remove(varName);
+
 					updateLayout();
 					changed = true;
 				}