Add saturating_add and saturating_sub to Instant #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more idiomatic since methods with these names usually take self and not &mut self.
Dirbaio
reviewed
Feb 4, 2025
|
|
||
| /// Adds a Duration to self. In case of overflow, the maximum value is returned. | ||
| pub fn saturating_add(mut self, duration: Duration) -> Self { | ||
| self.ticks = self.ticks.saturating_add(duration.ticks); |
There was a problem hiding this comment.
Mutating self is a bit strange. could you do Self::from_ticks(self.ticks.saturating_add(duration.ticks))?
same for sub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.