Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RPLE compatibility #121

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Added RPLE compatibility #121

merged 2 commits into from
Jun 25, 2024

Conversation

FalsePattern
Copy link
Contributor

The priority 300 BlockMixin conflicts with RPLE's BlockMixin getLightValue redirect https://github.com/GTMEGA/RPLE/blob/57ae27dcb9891f968e10f7b52fbd4d5b1382d093/src/main/java/com/falsepattern/rple/internal/mixin/mixins/common/BlockMixin.java#L60, this PR moves the conflicting redirect to priority 2000 so that the mixin engine is happy.

The Overwrite is necessary on RPLE's side, as an Inject with a cancel causes extreme object allocation spam, and an ASM transformer is too dirty.

Also fixed a bug in the buildscript that caused mrjtpcore to stall the build for 5 minutes due to a weird jitpack interaction.

Fixing the compat on ArchaicFix's side makes more sense, as AF is a generic hotfix/patch/performance mod while RPLE is a content mod.

@embeddedt embeddedt merged commit 63f882b into embeddedt:main Jun 25, 2024
1 check passed
@Roadhog360
Copy link

The Overwrite is necessary on RPLE's side, as an Inject with a cancel causes extreme object allocation spam, and an ASM transformer is too dirty.

Sorry for the necropost, was just reading old posts. UniMixins passes in null for unused CallbackInfo objects; could perhaps an inject at head work now? Just curious

@embeddedt
Copy link
Owner

The CallbackInfo is not unused if the method is being canceled.

@Roadhog360
Copy link

Whoops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants