-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIEB] Change Flickr30k to test split #1449
Merged
isaac-chung
merged 94 commits into
embeddings-benchmark:mieb
from
Jamie-Stirling:mieb-datasets
Nov 15, 2024
Merged
[MIEB] Change Flickr30k to test split #1449
isaac-chung
merged 94 commits into
embeddings-benchmark:mieb
from
Jamie-Stirling:mieb-datasets
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto mieb-blip Merge changes from main
…nto mieb-imagenet
…ty evaluation datasets
…nto mieb-run-tasks-fix
…nto mieb-datasets
…nto mieb-datasets
…nto mieb-datasets
…nto mieb-datasets
isaac-chung
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I ran these locally and yes it's much closer now. cc @gowitheflow-1998
CLIP benchmark: 0.834 / 0.949
Ours: 0.889 / 0.914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1434
Flickr30k was previously underperforming (CLIP) for Recall@5. Changing to the test split of only 5k images/25k captions moves performance to be much closer to CLIP benchmark.
Checklist
make test
.make lint
.