Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIEB] Change Flickr30k to test split #1449

Merged
merged 94 commits into from
Nov 15, 2024

Conversation

Jamie-Stirling
Copy link

@Jamie-Stirling Jamie-Stirling commented Nov 14, 2024

Fixes #1434

Flickr30k was previously underperforming (CLIP) for Recall@5. Changing to the test split of only 5k images/25k captions moves performance to be much closer to CLIP benchmark.

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Jamie-Stirling and others added 30 commits September 6, 2024 16:20
Jamie-Stirling and others added 28 commits October 20, 2024 20:34
Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I ran these locally and yes it's much closer now. cc @gowitheflow-1998

CLIP benchmark: 0.834 / 0.949
Ours: 0.889 / 0.914

@isaac-chung isaac-chung merged commit 7e0779a into embeddings-benchmark:mieb Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants