-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate mme5 models #2081
base: main
Are you sure you want to change the base?
Integrate mme5 models #2081
Conversation
mteb/models/mme5_models.py
It seems the mmE5 repo is not installable via |
You can copy their model class and other functions from library |
I see. Should I add the helper functions and model classes to the mme5_models.py (created) file itself? |
Yes, I think this is best option |
You should copy only required classes, not full repo |
I've only kept the required classes and functions and deleted the rest (only the directory structure has been maintained). Let me know if you still want them in the same file ie. mme5_models.py |
This seems a lot of files. I think we can wait until they convert to library or integrated to sentence transformers |
Noted. |
Changes/additions
mteb/models/mme5_models.py
mteb/models/mme5
Explanation for adding the mme5 folder:
haon-chen/mmE5 doesn't expose the the repository as a pip installable package, hence it is necessary to have the required model classes and functions (along with their dependencies) available locally. One option could have been to dump all these files in
mme5_models.py
itself, however, due to the large number of lines of code, this approach has been adopted.Closes #2079
Code Quality
make lint
to maintain consistent style.Documentation
Testing
make test-with-coverage
.make test
ormake test-with-coverage
to ensure no existing functionality is broken.Adding a model checklist
mteb.get_model(model_name, revision)
andmteb.get_model_meta(model_name, revision)