Synchronise S3 initialisation with ember-cli-deploy-s3
#144
+221
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobisjan thanks for this PR. Can you look into the test failures? |
bobisjan
force-pushed
the
sync-s3-init
branch
from
6b5c1f9 to
8a3debd
Compare
|
Tests passed locally, I had to restore |
bobisjan
force-pushed
the
sync-s3-init
branch
from
5ab0fcb to
e8debb6
Compare
bobisjan
force-pushed
the
sync-s3-init
branch
from
e8debb6 to
04a5756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides additional configuration options like session token for STS and proxy.
https://github.com/ember-cli-deploy/ember-cli-deploy-s3/blob/master/lib/s3.js#L10-L76