Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LTS page for data breaking lockstep #1073

Merged
merged 3 commits into from
May 3, 2024

Conversation

jaredgalanis
Copy link
Member

@jaredgalanis jaredgalanis commented Dec 18, 2023

2024-05-03 09 14 52

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 2db0f26
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/6634e7192480b00007ee0d7a
😎 Deploy Preview https://deploy-preview-1073--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 18, 2023

1/14 Files got Smaller 🎉:

Details
File raw gzip
ember-website.js -408 B -111 B

13/14 Files stayed the same size 🤷‍:

Details
File raw gzip
blurhash.js 0 B 0 B
chunk.143.js 0 B 0 B
chunk.177.js 0 B 0 B
chunk.178.js -2 B -2 B
chunk.208.js 0 B 0 B
chunk.488.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B -1 B

Created by ember-asset-size-action

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't give my feeback via text last time 🙈 I'll write them down this time so we don't forget 😂

  • there should be one table each per project and have headers that tell you what one they are for (ember-source or ember-data)
  • the heading for each table should be LTS version, Bugfixes until, Security patches until, and Status where status says end of life or active

@jaredgalanis jaredgalanis force-pushed the update-lts-page-for-data-versioning-strategy branch from 361b3e5 to 63bebc7 Compare May 3, 2024 12:31
@jaredgalanis jaredgalanis requested a review from mansona May 3, 2024 13:35
@jaredgalanis jaredgalanis changed the title WIP - rough pass on updating LTS page for data breaking lockstep Update LTS page for data breaking lockstep May 3, 2024
@jaredgalanis jaredgalanis marked this pull request as ready for review May 3, 2024 13:38
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! LGTM 💪

@jaredgalanis jaredgalanis merged commit 2607cd5 into main May 3, 2024
7 checks passed
@jaredgalanis jaredgalanis deleted the update-lts-page-for-data-versioning-strategy branch May 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants