Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Krystan HuffMenne to the Ember Data core team #1105

Conversation

kiwiupover
Copy link
Contributor

This PR adds Krystan HuffMenne to the Ember Data core team
and moves Scott Newcomber to alumni

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 9f9551f
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/6631dc006f2a640008fd6485
😎 Deploy Preview https://deploy-preview-1105--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Scott for your contributions 🙌

And congrats Krystan 👏

Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like two tests are failing. If you could make a quick adjustment to the assertions that would be great. Otherwise I can get back to it when I'm on a computer.

@IgnaceMaes
Copy link
Member

Thanks!

@IgnaceMaes IgnaceMaes merged commit d6592fe into ember-learn:main May 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants