Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4-main backports 2/11 #9679

Merged
merged 38 commits into from
Feb 18, 2025
Merged

v4-main backports 2/11 #9679

merged 38 commits into from
Feb 18, 2025

Conversation

gitKrystan
Copy link
Contributor

@gitKrystan gitKrystan commented Feb 11, 2025

Description

See commits

Notes for the release

runspired and others added 30 commits February 11, 2025 17:51
* Correctly configure package.json#exports for use with tsconfig.json#compilerOptions#types

Fix: #9630
Fix: ember-cli/ember-cli#10611

Related:
- ember-cli/ember-cli#10613

Unblocks:
- ember-cli/ember-cli#10612

* Fix lints by removing eslint cache

* Smoke Tests: dt-types pass

* Smoke: native-types pass

* ope

* Revert changes to vite-basic-compat

* lockfile

* Revert npmrc

* revert pnpm-lock

* Smoke tests don't need their own lint config

* Use correct script name

* Remove added files to vite-basic-compat

* Prettier

* Revert misguided lint-induced changes
* update TS guidance

* fix links

* fix line

* more guidance
* chore: make tests more splittable

* enable splitting by putting modules into separate files
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: get perf test harness working again

* update tracerbench

* bump tracerbench again

* bump tracerbench again

* bump tracerbench again

* bump tracerbench again

* bump tracerbench again

* make node 20 safe

* use ext

* bump tracerbench again

* fix import

* fix vite

* fix vite?
Add blog post on transformations and derivations
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: stub out linksMode work

* add links mode to upgraded meta

* finish up linksmode impl on meta

* Implement linksMode for sync belongsTo relationships

* Tidy up

* Fix lint

* Some ESLint cleanup

* Fix lint moar

* Implement legacy relationship support + linksMode reload

* Add model test

* Tidy up

* Clean up

* Clean up

* Clean up

* Error if linksMode but no links

* More error handling

* More validations

* Remove duplicate assertion

* Add reactivity test

* Fix tests/lint

* Fix validation for !object data

---------

Co-authored-by: Krystan HuffMenne <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: bump range for @ember/test-helpers to include 5.1

* fix override

* fix contexts?
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…re referentially equal (#9654)

* perf: dont notify for attribute changes that are referentially equal

* fix commit sha

* fix node version

* update tracerbench

* bump tracerbench again

* bump tracerbench again

* pass complex flags

* feat: use flags

* feat: use flags

* try again

* try again

* fix name

* fix hotspots

* fixup test signature

* feat: add nicer logs, fix emergent behavior
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
runspired and others added 6 commits February 11, 2025 18:45
* perf: reduce notifications on relationship remote state updates

* fix local replace semantics

* fix rollback/sort-order

* cleanup notifications mroe
* perf: reduce notifications during first-load

* perf: silence more notifications

* cleanup impl
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: fixup TODO tests

* fix todo test
@gitKrystan gitKrystan changed the base branch from main to v4-main February 11, 2025 23:51
@gitKrystan gitKrystan changed the title backports 211 v4-main backports 2/11 Feb 11, 2025
@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies labels Feb 12, 2025
imrpove handling of rollback scenarios
@gitKrystan gitKrystan added the ci-perf Activates Performance Checks in CI label Feb 13, 2025
Copy link

Performance Report for 2aba612

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -27ms [-34ms to -20ms] OR -1.64% [-2.06% to -1.22%]
⚠️ Phase [navigationStart] => [start-data-generation]
phase estimated regression +10ms [9ms to 10ms] OR +14.76% [13.82% to 15.74%]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 1ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -25ms [-30ms to -20ms] OR -3% [-3.63% to -2.38%]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -11ms [-15ms to -7ms] OR -2.35% [-3.26% to -1.46%]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [0ms to 0ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 4ms]
⚠️ Phase [navigationStart] => [start-find-all]
phase estimated regression +10ms [9ms to 10ms] OR +14.9% [14.03% to 15.78%]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -9ms [-12ms to -7ms] OR -4.26% [-5.41% to -3.21%]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-4ms to 2ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [0ms to 0ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [0ms to 38ms]
⚠️ Phase [navigationStart] => [start-data-generation]
phase estimated regression +10ms [9ms to 10ms] OR +14.98% [13.82% to 15.8%]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 0ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -7ms [-11ms to -4ms] OR -1.8% [-2.75% to -0.92%]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-3ms to 2ms]
⚠️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated regression +16ms [3ms to 29ms] OR +1.08% [0.19% to 1.93%]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [0ms to 3ms]

Scenario - unload: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +4ms [1ms to 8ms] OR +0.85% [0.27% to 1.48%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +10ms [10ms to 11ms] OR +7.39% [6.81% to 7.95%]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -7ms [-10ms to -5ms] OR -3.4% [-4.61% to -2.22%]
⚠️ Phase [start-unload-records] => [end-unload-records]
phase estimated regression +1ms [0ms to 2ms] OR +0.89% [0.05% to 1.79%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-1ms to 19ms]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +15ms [13ms to 16ms] OR +6.58% [6.04% to 7.16%]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -8ms [-12ms to -4ms] OR -1.56% [-2.44% to -0.8%]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-1ms to 5ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-4ms to 5ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - destroy: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +10ms [6ms to 15ms] OR +2.22% [1.37% to 3.23%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +10ms [9ms to 11ms] OR +6.95% [6.26% to 7.61%]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -6ms [-8ms to -3ms] OR -2.55% [-3.86% to -1.21%]
⚠️ Phase [start-destroy-records] => [end-destroy-records]
phase estimated regression +4ms [2ms to 7ms] OR +4.71% [2.18% to 7.8%]
⚠️ Phase [end-destroy-records] => [Test End]
phase estimated regression +1ms [1ms to 2ms] OR +4.2% [2.26% to 6.17%]

Scenario - add-children: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +3ms [0ms to 6ms] OR +0.76% [0.07% to 1.42%]
⚠️ Phase [navigationStart] => [start-push-initial-payload]
phase estimated regression +11ms [10ms to 11ms] OR +6.29% [5.85% to 6.72%]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -4ms [-5ms to -2ms] OR -3.43% [-4.78% to -2.05%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -4ms [-6ms to -2ms] OR -3.88% [-5.52% to -2.35%]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unused-relationships: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +6ms [3ms to 9ms] OR +1.42% [0.67% to 2.23%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +10ms [10ms to 11ms] OR +7.25% [6.65% to 7.84%]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -5ms [-7ms to -2ms] OR -2.3% [-3.27% to -1.12%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 1ms]

Copy link

github-actions bot commented Feb 13, 2025

Commit v Release Performance Report for 00828c9

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -144ms [-160ms to -129ms] OR -8.09% [-8.97% to -7.25%]
⚠️ Phase [navigationStart] => [start-data-generation]
phase estimated regression +10ms [9ms to 11ms] OR +15.06% [13.98% to 16.09%]
⚠️ Phase [start-data-generation] => [start-push-payload]
phase estimated regression +2ms [1ms to 4ms] OR +0.96% [0.42% to 1.49%]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -180ms [-189ms to -171ms] OR -18.14% [-19.06% to -17.23%]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
⚠️ Phase [start-record-materialization] => [end-record-materialization]
phase estimated regression +29ms [23ms to 35ms] OR +7% [5.59% to 8.27%]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - relationship-materialization-simple: ✅ Performance improved

✅ duration
phase estimated improvement -5ms [-9ms to -1ms] OR -0.98% [-1.68% to -0.21%]
⚠️ Phase [navigationStart] => [start-find-all]
phase estimated regression +10ms [9ms to 10ms] OR +15.03% [14.12% to 15.86%]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -18ms [-20ms to -15ms] OR -7.72% [-8.88% to -6.59%]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-1ms to 5ms]
⚠️ Phase [end-materialization] => [Test End]
phase estimated regression +1ms [0ms to 1ms] OR +2.17% [0.94% to 3.18%]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -80ms [-104ms to -59ms] OR -3.16% [-4.08% to -2.34%]
⚠️ Phase [navigationStart] => [start-data-generation]
phase estimated regression +10ms [9ms to 11ms] OR +15.33% [14.11% to 16.63%]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 1ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -61ms [-66ms to -56ms] OR -13.43% [-14.54% to -12.29%]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
✅ Phase [start-record-materialization] => [start-relationship-materialization]
phase estimated improvement -40ms [-43ms to -37ms] OR -18.65% [-20% to -17.24%]
⚠️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated regression +25ms [8ms to 43ms] OR +1.67% [0.54% to 2.86%]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -17ms [-19ms to -15ms] OR -9.5% [-10.61% to -8.45%]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -27ms [-30ms to -23ms] OR -4.84% [-5.44% to -4.17%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +10ms [10ms to 11ms] OR +7.39% [6.84% to 7.88%]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -35ms [-38ms to -33ms] OR -14.3% [-15.45% to -13.23%]
✅ Phase [start-unload-records] => [end-unload-records]
phase estimated improvement -2ms [-4ms to -1ms] OR -1.63% [-2.71% to -0.56%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -65ms [-73ms to -56ms] OR -4.69% [-5.27% to -4.04%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +15ms [13ms to 16ms] OR +6.73% [5.95% to 7.36%]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -99ms [-103ms to -95ms] OR -16.64% [-17.23% to -16.01%]
⚠️ Phase [start-materialization] => [start-unload-all]
phase estimated regression +21ms [17ms to 25ms] OR +9.33% [7.77% to 11.1%]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-5ms to 4ms]
✅ Phase [end-unload-all] => [Test End]
phase estimated improvement -2ms [-2ms to -2ms] OR -5.9% [-7.08% to -4.64%]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -64ms [-68ms to -60ms] OR -11.95% [-12.69% to -11.24%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +10ms [9ms to 11ms] OR +7.1% [6.67% to 7.52%]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -36ms [-38ms to -33ms] OR -14.81% [-15.73% to -13.86%]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -12ms [-15ms to -9ms] OR -12.52% [-15.39% to -9.06%]
✅ Phase [end-destroy-records] => [Test End]
phase estimated improvement -30ms [-31ms to -30ms] OR -53.52% [-54.53% to -52.29%]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -19ms [-23ms to -16ms] OR -4.61% [-5.47% to -3.77%]
⚠️ Phase [navigationStart] => [start-push-initial-payload]
phase estimated regression +10ms [10ms to 11ms] OR +6.29% [5.8% to 6.73%]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -14ms [-16ms to -12ms] OR -12.05% [-13.59% to -10.62%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -16ms [-19ms to -14ms] OR -14.89% [-17.34% to -12.71%]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -26ms [-29ms to -23ms] OR -6.4% [-7.01% to -5.69%]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +10ms [9ms to 10ms] OR +6.97% [6.54% to 7.39%]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -35ms [-38ms to -33ms] OR -14.68% [-15.66% to -13.76%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

@gitKrystan gitKrystan merged commit f8ad07a into v4-main Feb 18, 2025
20 of 22 checks passed
@gitKrystan gitKrystan deleted the backports-211 branch February 18, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-perf Activates Performance Checks in CI 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants