Skip to content

Commit

Permalink
Pin @octokit/core to v4 due to temporary incompatible peers
Browse files Browse the repository at this point in the history
release-it and release-it-lerna-changelog have incompatible peers.

The original error:
```

 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
└─┬ release-it
  └─┬ @octokit/rest
    └─┬ @octokit/plugin-paginate-rest
      └── ✕ unmet peer @octokit/core@>=4: found 3.6.0 in @octokit/rest

hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.
```
  • Loading branch information
NullVoxPopuli committed Jul 21, 2022
1 parent 4620690 commit e5f4847
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 29 deletions.
8 changes: 8 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,14 @@
"publish": false
}
},
"pnpm": {
"overrides": {
"@octokit/core": "^4.0.0"
},
"overrides-notes": {
"@octokit/core": "release-it -> @octokit/rest -> @octokit/plugin-paginate-rest wants @octokit/core v4, but found 3.6. The problem is that release-it-lerna-changelog + release-it have incompatible peers. This 'fix' relies on the accident that @octokit/core happens to work with all the other deps"
}
},
"volta": {
"node": "14.20.0",
"yarn": "1.22.11"
Expand Down
67 changes: 38 additions & 29 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e5f4847

Please sign in to comment.